Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing the configcheck command if the instances is empty #3704

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

hush-hush
Copy link
Member

No description provided.

@hush-hush hush-hush force-pushed the maxime/fix-checkconfig-command branch from 50c2af1 to da323a5 Compare March 15, 2018 14:25
from config import (
check_yaml,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hush-hush hush-hush merged commit f6efee3 into master Mar 15, 2018
@hush-hush hush-hush deleted the maxime/fix-checkconfig-command branch March 15, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants