Remove API key if included in processes metadata payload #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
requested changes
Mar 20, 2018
| @@ -529,6 +529,8 @@ def run(self, checksd=None, start_event=True, configs_reloaded=False): | |||
| del data['metrics'] | |||
| del data['events'] | |||
| del data['service_checks'] | |||
| if data.get('processes'): | |||
| data['processes']['apiKey'] = '*************************' + data['processes'].get('apiKey', '')[-5:] | |||
There was a problem hiding this comment.
Minor nit: maybe do '*' * 27 to make the scrubbed key the proper length (32)
There was a problem hiding this comment.
Don't worry since the flare also doesn't output the proper length
Line 105 in 1d0dc34
ofek
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Removes API key if included as part of the
processesfield in the metadata payload when log level is set toDEBUGMotivation
Noticed an API key, as part of the processes field, could be sent if
DEBUGmode is enabledTesting Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?