[IO] Fix on newer versions of iostat + tests + misc fix #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
force-pushed
the
olivielpeau/fix-newer-iostat
branch
from
5a01a54
to
0074a26
Compare
ofek
approved these changes
May 9, 2018
This reverts part of commit b74d12f (migration of checks to integrations-core). Remove network check tests since these are indeed in integrations-core now.
Was missing a cast to float. Caught by the test that had been missing, deserves more tests though.
Along with test changes. Newer iostat versions also expose slightly different fields. I don't think we need to take care of these differences now.
olivielpeau
force-pushed
the
olivielpeau/fix-newer-iostat
branch
from
0ef22f6
to
bec521f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3731 , i.e. fixes core
IOcheck on newer versions ofiostat.In the process of fixing this issue, I found tests for this part of the code that had been wrongly removed in #3114 (migration of checks to
integrations-core). So I've:system.io.utilto 100%聽#3727, and fixed that bug.Testing
We have tests again :)
And I've added a test case for the newer iostat output format.
Additional Notes
See individual commit descriptions for the full story 馃摉
cc @ChristineTChen: could you add more tests on the code you added in #3727? I've only changed the minimum amount of code to fix
the existing logic and the tests, but the new logic deserves more tests.