Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicilty pin urllib to avoid python-etcd to pull latest #3746

Merged
merged 1 commit into from Jun 5, 2018
Merged

Explicilty pin urllib to avoid python-etcd to pull latest #3746

merged 1 commit into from Jun 5, 2018

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 5, 2018 •
edited

What does this PR do?

See title

Motivation

pip install -r requirements.txt is currently broken, see https://ci.appveyor.com/project/Datadog/integrations-core/build/master.5840

python-etcd lists urllib requirement as urllib3>=1.7.1 which clashes with the one from requests==2.18.4 that is urllib3<1.23,>=1.21.1

truthbk
truthbk approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masci! :shipit:

@masci masci merged commit 5deb1a2 into master Jun 5, 2018
@masci masci deleted the massi/pin-urllib branch June 5, 2018 09:07
@truthbk truthbk added this to the 5.25.0 milestone Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.25.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masci @truthbk