Sets apm enabled by default (if there's no indication in the config #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Jun 6, 2018
There was a problem hiding this comment.
LGTM!
@palazzem can you confirm that on Windows Agent5, we want to enable the trace agent by default?
palazzem
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
@olivielpeau yes that would reduce the friction to use our C# tracer once it's out. Thank you very much!
|
Great, thanks for the confirmation @palazzem! Let's merge this for 5.25.0 then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file)
What does this PR do?
Sets the default state for APM to be enabled if not set in the config file
Motivation
Make behavior consistent between agent5 and agent6
Windows agent uses this value to determine whether to start the apm service on main service startup (the service will not be started automatically by the service control manager).