Proxy support for the agent #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| proxies = urllib.getproxies() | ||
| proxy = proxies.get('https', None) | ||
| try: | ||
| proxy = proxy.split('://')[1] |
There was a problem hiding this comment.
Maybe use urlparse instead?
There was a problem hiding this comment.
urlparse is not great (at least on old python versions)
>>> urlparse('https://user:password@host:1234')
('https', 'user:password@host:1234', '', '', '', '')
>>> urlparse('user:password@host:1234')
('user', '', 'password@host:1234', '', '', '')So I'm going to keep this parsing.
|
Looks great! My only question is: are there any licenses we need to include for the 3rd-party stuff we're packaging? |
|
I didn't see any: |
|
Ah cool, I didn't realize it was just a patch to stdlib python. Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the forwarder is installed, it uses tornado's CurlAsyncHttpClient
CurlAsyncHttpClient requires PyCurl which is not easily installable from source.
Therefore proxy support won't be working on source installation of the agent
If the forwarder is not used it uses urllib2 in the emitter.
Warning:
It has been tested on:
DogstatsD doens't implement proxy support as it's local traffic in most cases.