New source install script #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Also, I need to make sure that the dogweb endpoint for failure reporting is functional (was created months ago) |
|
Also do not merge until it's 100% ready, merging it to master would mean that it would be used on prod by everyone installing the agent using the source install. |
| printf "$1" | tee -a $logfile | ||
|
|
||
| while true; do | ||
| read -p "Do you want to send a failure report to Datadog ? (y/n)" yn |
There was a problem hiding this comment.
Before you ask for confirmation, you should dump out the report so they can look at it
|
Besides the comments, it looks great. Did you test on Linux too? |
|
|
||
| # Function to display a message passed as an argument in red and then exit | ||
| quit_error() { | ||
| printf "\033[31m" |
There was a problem hiding this comment.
Probably worth having constants for these color delimiters
In case supervisord is not running.
Conflicts: packaging/datadog-agent/source/agent packaging/datadog-agent/source/info
|
Should also fix #449 if file logging is turned off by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #476
Fix #473
Fix #378
Fix #139
Fix #478