add HDFS check using snakebite #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,46 @@ | |||
| from checks import AgentCheck | |||
|
|
|||
| import snakebite.client | |||
There was a problem hiding this comment.
Can you make this import within the check method so it won't crash if the module is missing ?
Something like
try:
import snakebite.client
except ImportError:
raise Exception("Snake bite module is not installed. Please install it using easy install")
|
@remh updated pull request per your feedback. |
| self.gauge('hdfs.used', stats['used']) | ||
| self.gauge('hdfs.free', stats['remaining']) | ||
| self.gauge('hdfs.capacity', stats['capacity']) | ||
| self.gauge('hdfs.in_use', float(stats['used']) / float(stats['capacity'])) |
There was a problem hiding this comment.
should this be surrounded by a try except to catch a possible ZeroDivisionError or the capacity will never be 0 ? (I don't really know hdfs)
There was a problem hiding this comment.
I can do that if you like. It's very unlikely for the capacity (in bytes) to be 0 -- that would probably only happen if the hadoop cluster were seriously broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snakebite is a direct client of the HDFS NameNode -- https://github.com/spotify/snakebite. Apache 2.0 License.