Made HTTP check tag aware #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,8 @@ class HTTPCheck(ServicesCheck): | |||
|
|
|||
| def _load_conf(self, instance): | |||
| # Fetches the conf | |||
| name = instance.get('name', None) | |||
There was a problem hiding this comment.
What is the name used for ? You don't use it anywhere.
|
Thanks for this pull request! |
|
I made the fixes. Thank you for responding quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http_check wasn't tag aware. This is problematic when checking multiple virtual hosts on the server that the agent is running on. In such a scenario all of the URLs would be http://localhost and only the "Host" header would be changed; They would all be tagged as url:http://localhost without an ability to add extra tags.
In a scenario where there might be multiple web servers behind a load balancer it's important to be able to check each web server's health instead of referring to the website's URL which would be a VIP shared by the cluster.