Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tags with http service check #780

Merged
merged 2 commits into from
Jan 9, 2014
Merged

Conversation

bakins
Copy link

@bakins bakins commented Jan 1, 2014

This makes each check searchable for events, etc, by tag rather than having to tag the host.

@remh
Copy link
Contributor

remh commented Jan 7, 2014

Thanks @bakins !
We should probably also add the url as a tag as we do for the response time metric
https://github.com/bakins/dd-agent/blob/c781e021b924d352d250e8b0e9e60d43789856f0/checks.d/http_check.py#L58-L60

Can you add that?

@bakins
Copy link
Author

bakins commented Jan 7, 2014

Added. currently untested. Should maybe do that in a helper function as we have same logic in two places

@remh
Copy link
Contributor

remh commented Jan 9, 2014

Thanks!

remh added a commit that referenced this pull request Jan 9, 2014
Include tags with http service check
@remh remh merged commit adbed3e into DataDog:master Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants