Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bind_host parameter to support Openshift integration (localhost can't be used) #875

Merged
merged 3 commits into from Apr 7, 2014

Conversation

QuentinFra
Copy link
Member

@remh Here are the modifications I made to be able to configure a custom loopback address. I tested it with Openshift, it seems to work. Any feedback on your side?

@alq666
Copy link
Member

alq666 commented Mar 19, 2014

Is it because the gears are IPv6 only?

@alq666
Copy link
Member

alq666 commented Mar 19, 2014

Actually no, I saw that they were not this morning.

@QuentinFra
Copy link
Member Author

You can't use 'localhost' on a gear, you actually need to bind the internal IP which starts with 127.xxx. That was the source of my errors...

@alq666
Copy link
Member

alq666 commented Mar 24, 2014

@qqfr2507 do you need anyone to review?

@QuentinFra
Copy link
Member Author

Yes, I don't know if @remh had time to have a look at it yet.

@alq666
Copy link
Member

alq666 commented Mar 24, 2014

Looks good to me. @remh should we wait until you cut the 4.2 release?

@alq666
Copy link
Member

alq666 commented Apr 7, 2014

@qqfr2507 does this still need to be merged for openshift to work?

@QuentinFra
Copy link
Member Author

No, it can work without the merge (because I copied the agent installation
code in the Openshift cartridge).

Quentin

On Sun, Apr 6, 2014 at 11:55 PM, Alexis Lê-Quôc notifications@github.comwrote:

@qqfr2507 https://github.com/qqfr2507 does this still need to be merged
for openshift to work?

Reply to this email directly or view it on GitHubhttps://github.com//pull/875#issuecomment-39694345
.

@@ -3,6 +3,9 @@
# The host of the Datadog intake server to send Agent data to
dd_url: https://app.datadoghq.com

# The loopback address the Agent will bind
bind_host: localhost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment that line so it reflects that this parameter is optional ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@remh remh merged commit 0f5c0d5 into master Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants