Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tristan/agent checks ui #922

Merged
merged 12 commits into from May 19, 2014
Merged

Tristan/agent checks ui #922

merged 12 commits into from May 19, 2014

Conversation

tmichelet
Copy link
Contributor

No description provided.

@@ -297,6 +297,14 @@ def run(self, checksd=None, start_event=True):
payload['metrics'] = metrics
payload['events'] = events
payload['service_checks'] = service_checks

# Add agent_chekcs if needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -2,6 +2,8 @@

class Gearman(AgentCheck):

SOURCE_TYPE_NAME = 'germand'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here

@tmichelet
Copy link
Contributor Author

Checks marathon and mesos are still missing a SOURCE_TYPE_NAME, what's their source_type_name?
(https://github.com/DataDog/dogweb/blob/prod/dd/utils/context/source.py)

@clofresh
Copy link
Contributor

clofresh commented May 8, 2014

You can just use marathon and mesos

@tmichelet
Copy link
Contributor Author

OK thanks, nothing to update then

@remh remh added this to the 4.3.x milestone May 8, 2014
@@ -2,6 +2,8 @@

class Gearman(AgentCheck):

SOURCE_TYPE_NAME = 'gearmand'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need that one as the check name is also gearmand, do we ?

@remh
Copy link
Contributor

remh commented May 19, 2014

Thanks! It looks great!
Can you fix the two small nitpicks i mentioned and merge ?

tmichelet added a commit that referenced this pull request May 19, 2014
@tmichelet tmichelet merged commit 6780b3f into master May 19, 2014
@tmichelet tmichelet deleted the tristan/agent-checks-ui branch May 19, 2014 22:12
@remh
Copy link
Contributor

remh commented May 19, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants