Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor capabilities #227

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Refactor capabilities #227

merged 3 commits into from
Mar 24, 2023

Conversation

estringana
Copy link
Collaborator

Description

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@estringana estringana force-pushed the estrignana/refactor-capabilities branch 2 times, most recently from e6b67d8 to 1a92ffb Compare March 21, 2023 11:42
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #227 (500a5d8) into master (689b683) will decrease coverage by 10.08%.
The diff coverage is 77.04%.

@@             Coverage Diff             @@
##           master     #227       +/-   ##
===========================================
- Coverage   63.95%   53.88%   -10.08%     
===========================================
  Files          88       63       -25     
  Lines        5591     2342     -3249     
  Branches     1779     1045      -734     
===========================================
- Hits         3576     1262     -2314     
+ Misses        948      396      -552     
+ Partials     1067      684      -383     
Flag Coverage Δ
extension ?
helper 53.88% <77.04%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helper/remote_config/listener.hpp 100.00% <ø> (ø)
src/helper/remote_config/product.cpp 50.00% <ø> (ø)
src/helper/service.hpp 100.00% <ø> (ø)
src/helper/service_config.hpp 100.00% <ø> (ø)
src/helper/service_manager.hpp 100.00% <ø> (ø)
src/helper/remote_config/client.cpp 50.64% <47.61%> (-1.81%) ⬇️
src/helper/remote_config/product.hpp 81.81% <66.66%> (-5.69%) ⬇️
src/helper/service.cpp 72.88% <66.66%> (+6.75%) ⬆️
src/helper/client.cpp 41.94% <100.00%> (-0.86%) ⬇️
src/helper/engine_settings.hpp 75.00% <100.00%> (ø)
... and 8 more

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estringana estringana requested a review from Anilm3 March 21, 2023 12:15
@estringana estringana marked this pull request as ready for review March 21, 2023 12:15
@estringana estringana force-pushed the estrignana/refactor-capabilities branch from 1a92ffb to 185f8ff Compare March 21, 2023 12:17
src/helper/remote_config/listener.hpp Outdated Show resolved Hide resolved
src/helper/client.cpp Outdated Show resolved Hide resolved
src/helper/remote_config/asm_data_listener.hpp Outdated Show resolved Hide resolved
src/helper/remote_config/client.cpp Outdated Show resolved Hide resolved
src/helper/remote_config/client.hpp Outdated Show resolved Hide resolved
src/helper/remote_config/client.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana force-pushed the estrignana/refactor-capabilities branch from 18e6b73 to b6518fb Compare March 24, 2023 12:10
@estringana estringana force-pushed the estrignana/refactor-capabilities branch from b6518fb to 500a5d8 Compare March 24, 2023 12:11
@estringana estringana merged commit 274e64f into master Mar 24, 2023
@estringana estringana deleted the estrignana/refactor-capabilities branch March 24, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants