Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract methods of listener on test #239

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

estringana
Copy link
Collaborator

Description

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

Codecov Report

Merging #239 (ebcc765) into master (67feca5) will decrease coverage by 10.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #239       +/-   ##
===========================================
- Coverage   63.92%   53.35%   -10.57%     
===========================================
  Files          88       63       -25     
  Lines        5655     2369     -3286     
  Branches     1794     1056      -738     
===========================================
- Hits         3615     1264     -2351     
+ Misses        969      417      -552     
+ Partials     1071      688      -383     
Flag Coverage Δ
extension ?
helper 53.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estringana estringana marked this pull request as ready for review April 6, 2023 09:36
@estringana estringana merged commit 403dd11 into master Apr 6, 2023
23 checks passed
@estringana estringana deleted the estringana/amend-leaks-on-tests branch April 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants