Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure path parser does not count on /config ending #240

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

estringana
Copy link
Collaborator

Description

Remote configuration documentation was a bit confusing on wether or not paths had to end on /config. In some other languages, path were expected like that. However, it's been clarified that paths don't have to come with /config at the end. This PR just modify one unit tests to ensure this is not the case in php

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@estringana estringana requested a review from Anilm3 April 6, 2023 15:43
@estringana estringana marked this pull request as ready for review April 11, 2023 08:43
@estringana estringana merged commit 52a5661 into master Apr 12, 2023
22 checks passed
@estringana estringana deleted the estringana/add-test-to-clarify-documentation branch April 12, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants