Set appsec disabled when ddtrace is not enabled #245
Merged
+119
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 63.54% 71.13% +7.58%
==========================================
Files 94 25 -69
Lines 5635 3236 -2399
Branches 1802 721 -1081
==========================================
- Hits 3581 2302 -1279
+ Misses 974 560 -414
+ Partials 1080 374 -706
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 69 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Anilm3
requested changes
Apr 18, 2023
estringana
force-pushed
the
estringana/disable-appsec-if-no-tracer
branch
from
4494ff5
to
cadf016
Compare
Anilm3
reviewed
Apr 25, 2023
estringana
force-pushed
the
estringana/disable-appsec-if-no-tracer
branch
from
0ec843a
to
3e14f05
Compare
estringana
force-pushed
the
estringana/disable-appsec-if-no-tracer
branch
from
3e14f05
to
a216b1d
Compare
estringana
force-pushed
the
estringana/disable-appsec-if-no-tracer
branch
from
1a1d852
to
4f1c1f0
Compare
Anilm3
reviewed
Apr 27, 2023
Anilm3
approved these changes
Apr 27, 2023
Co-authored-by: Anil Mahtani <929854+Anilm3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases that customers disabled ddtrace but not appsec. On those cases we don't want appsec extension to be enabled.
Motivation
Additional Notes
Describe how to test your changes
Readiness checklist
Release checklist