Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine update batcher #248

Merged
merged 11 commits into from
Apr 25, 2023
Merged

Engine update batcher #248

merged 11 commits into from
Apr 25, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Apr 20, 2023

Description

  • Shift remote_config::listener ownership from remote_config::product to remote_config::client
  • Allow a remote_config::listener to handle multiple products
  • Perform init / commit before assigning configurations in remote_config::product
  • Introduce remote_config::engine_listener which handles all engine updates in a single listener
  • Replace remote_config::asm_listener, remote_config::asm_dd_listener, remote_config::asm_data_listener with similar config aggregators

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #248 (9f2d9e8) into master (3ad61e0) will decrease coverage by 10.38%.
The diff coverage is 57.32%.

@@             Coverage Diff             @@
##           master     #248       +/-   ##
===========================================
- Coverage   63.68%   53.31%   -10.38%     
===========================================
  Files          90       69       -21     
  Lines        5606     2401     -3205     
  Branches     1776     1076      -700     
===========================================
- Hits         3570     1280     -2290     
+ Misses        971      423      -548     
+ Partials     1065      698      -367     
Flag Coverage Δ
extension ?
helper 53.31% <57.32%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helper/json_helper.hpp 83.33% <ø> (ø)
src/helper/remote_config/client.hpp 100.00% <ø> (ø)
.../remote_config/listeners/asm_features_listener.cpp 58.33% <ø> (ø)
src/helper/remote_config/product.cpp 52.50% <ø> (+2.50%) ⬆️
src/helper/utils.hpp 83.33% <ø> (ø)
src/helper/utils.cpp 29.41% <29.41%> (ø)
src/helper/remote_config/client_handler.cpp 73.97% <42.85%> (+3.45%) ⬆️
...listeners/config_aggregators/asm_dd_aggregator.cpp 46.15% <46.15%> (ø)
src/helper/remote_config/client.cpp 51.06% <50.00%> (-0.05%) ⬇️
.../remote_config/listeners/asm_features_listener.hpp 66.66% <50.00%> (ø)
... and 13 more

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 marked this pull request as ready for review April 24, 2023 14:36
@Anilm3 Anilm3 merged commit 25ec4c4 into master Apr 25, 2023
22 checks passed
@Anilm3 Anilm3 deleted the anilm3/engine-update-batcher branch April 25, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants