Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-only engine listener and atomic config handling #253

Merged
merged 3 commits into from
May 3, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented May 2, 2023

Description

  • Make config aggregators atomic, i.e. a configuration with an error does not result in any changes.
  • Update engine listener to avoid affecting products without updates, removals or new configs.

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #253 (aa3b45d) into master (f9fb3c7) will decrease coverage by 10.64%.
The diff coverage is 43.18%.

@@             Coverage Diff             @@
##           master     #253       +/-   ##
===========================================
- Coverage   63.83%   53.19%   -10.64%     
===========================================
  Files          94       69       -25     
  Lines        5660     2455     -3205     
  Branches     1808     1108      -700     
===========================================
- Hits         3613     1306     -2307     
+ Misses        984      436      -548     
+ Partials     1063      713      -350     
Flag Coverage Δ
extension ?
helper 53.19% <43.18%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ig/listeners/config_aggregators/asm_aggregator.hpp 66.66% <0.00%> (ø)
...steners/config_aggregators/asm_data_aggregator.hpp 83.33% <0.00%> (ø)
...helper/remote_config/listeners/engine_listener.hpp 66.66% <ø> (ø)
...listeners/config_aggregators/asm_dd_aggregator.cpp 31.57% <18.18%> (-14.58%) ⬇️
...helper/remote_config/listeners/engine_listener.cpp 50.00% <31.57%> (-6.25%) ⬇️
...ig/listeners/config_aggregators/asm_aggregator.cpp 50.00% <38.88%> (-2.00%) ⬇️
...steners/config_aggregators/asm_data_aggregator.cpp 54.08% <60.52%> (+1.85%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 marked this pull request as ready for review May 2, 2023 15:59
@Anilm3 Anilm3 merged commit 73b61e0 into master May 3, 2023
48 checks passed
@Anilm3 Anilm3 deleted the anilm3/atomic-listeners-and-fixes branch May 3, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants