Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tracer state detection #305

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Sep 28, 2023

Description

This PR fixes two different problems:

  • Distinguishing between the tracer being enabled and being loaded, the former shouldn't prevent appsec from loading symbols while the latter should.
  • Obtaining the correct tracer enabled state during the request lifecycle.

Related ticket: APPSEC-11407

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #305 (9af4cff) into master (3a42eb1) will increase coverage by 8.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   64.15%   72.19%   +8.03%     
==========================================
  Files          95       25      -70     
  Lines        6026     3438    -2588     
  Branches     1952      787    -1165     
==========================================
- Hits         3866     2482    -1384     
+ Misses       1008      562     -446     
+ Partials     1152      394     -758     
Flag Coverage Δ
extension 72.19% <66.66%> (-0.04%) ⬇️
helper ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/extension/user_tracking.c 67.92% <100.00%> (ø)
src/extension/ddtrace.c 66.86% <83.33%> (+0.39%) ⬆️
src/extension/ddappsec.c 77.82% <0.00%> (ø)

... and 71 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

estringana
estringana previously approved these changes Sep 28, 2023
@Anilm3 Anilm3 marked this pull request as ready for review September 28, 2023 14:37
@Anilm3 Anilm3 requested a review from a team as a code owner September 28, 2023 14:37
@Anilm3 Anilm3 merged commit bea00b3 into master Sep 28, 2023
29 checks passed
@Anilm3 Anilm3 deleted the anilm3/improve-tracer-availability-detection branch September 28, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants