Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression library to helper #316

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

estringana
Copy link
Collaborator

Description

Related: APPSEC-11210

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@estringana estringana force-pushed the estringana/add-compression-library branch from b50cf5b to 241f420 Compare November 17, 2023 15:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (969d87c) 64.19% compared to head (49f2446) 64.20%.

Files Patch % Lines
src/helper/compression.cpp 69.38% 2 Missing and 13 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   64.19%   64.20%           
=======================================
  Files          96       97    +1     
  Lines        6078     6127   +49     
  Branches     1966     1982   +16     
=======================================
+ Hits         3902     3934   +32     
- Misses       1018     1022    +4     
- Partials     1158     1171   +13     
Flag Coverage Δ
extension 72.10% <ø> (-0.06%) ⬇️
helper 54.15% <69.38%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estringana estringana force-pushed the estringana/add-compression-library branch from 241f420 to ac56ca0 Compare November 17, 2023 16:33
@estringana estringana force-pushed the estringana/add-compression-library branch from 4537389 to 09b9e3e Compare November 20, 2023 16:24
@estringana estringana force-pushed the estringana/add-compression-library branch 2 times, most recently from 0b16a7f to 9d7f986 Compare November 21, 2023 12:28
@estringana estringana force-pushed the estringana/add-compression-library branch from 9d7f986 to 3f7e744 Compare November 21, 2023 15:30
@estringana estringana marked this pull request as ready for review November 21, 2023 16:29
@estringana estringana requested a review from a team as a code owner November 21, 2023 16:29
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Show resolved Hide resolved
cataphract
cataphract previously approved these changes Nov 23, 2023
src/helper/compression.cpp Outdated Show resolved Hide resolved
src/helper/compression.cpp Show resolved Hide resolved
src/helper/compression.cpp Outdated Show resolved Hide resolved
@estringana estringana merged commit 5910249 into master Nov 23, 2023
34 checks passed
@estringana estringana deleted the estringana/add-compression-library branch November 23, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants