Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for envoy v1.15 and v1.16 #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add examples for envoy v1.15 and v1.16 #156

wants to merge 1 commit into from

Conversation

cgilmour
Copy link
Contributor

@cgilmour cgilmour commented Dec 9, 2020

Other minor changes

  • bump version numbers for older containers
  • add version to service name

@cgilmour
Add examples for envoy v1.15 and v1.16
3aa4895 
Other minor changes
- bump version numbers for older containers
- add version to service name
@dgoffredo
Copy link
Contributor

I was looking at this PR.

Checked out the branch, and ran ./check_envoy_configs.sh in examples/envoy-tracing/. It hanged after the following error:

Creating envoy-tracing_dd-agent_1 ... done
Creating envoy-tracing_envoy-v1.13_1   ... done
Creating envoy-tracing_envoy-v1.14_1   ... done
Creating envoy-tracing_envoy-v1.11_1   ... done
Creating envoy-tracing_envoy-v1.15_1   ... done
Creating envoy-tracing_envoy-ed6a1b8_1 ... done
Creating envoy-tracing_envoy-v1.12_1   ... done
Creating envoy-tracing_envoy-v1.16_1   ... done
curl: (28) Failed to connect to 172.20.0.9 port 80: Connection timed out

The script could be improved by adding a call to docker-compose down in a trap handler.

Is this PR needed anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgilmour @dgoffredo