Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.7, AGP to 8.4.0 #253

Merged
merged 3 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Setup Gradle
uses: gradle/gradle-build-action@v2.4.2
with:
gradle-version: 8.6
gradle-version: 8.7

# Manually build the java bytecode
- name: Execute Gradle build
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ include:
# SETUP

variables:
CURRENT_CI_IMAGE: "7"
CURRENT_CI_IMAGE: "8"
CI_IMAGE_DOCKER: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/dd-sdk-android-gradle-plugin:$CURRENT_CI_IMAGE
GIT_DEPTH: 5

Expand Down
3 changes: 0 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ The whole project is covered by a set of static analysis tools, linters and test
# launches the unit tests
./gradlew :dd-sdk-android-gradle-plugin:test

# launches the detekt static analysis
./gradlew :dd-sdk-android-gradle-plugin:detekt

# launches the ktlint check and formatter for all Kotlin files (the ktlint client needs to be installed on your machine)
ktlint -F "**/*.kt" "**/*.kts" '!**/build/generated/**' '!**/build/kspCaches/**'

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.gitlab
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ RUN set -x \
&& apt-get -y clean \
&& rm -rf /var/lib/apt/lists/*

ENV GRADLE_VERSION 8.6
ENV GRADLE_VERSION 8.7
ENV ANDROID_COMPILE_SDK 34
ENV ANDROID_BUILD_TOOLS 34.0.0
ENV ANDROID_SDK_TOOLS 11076708
ENV NDK_VERSION 25.1.8937393
ENV NDK_VERSION 26.1.10909125
ENV CMAKE_VERSION 3.22.1


Expand Down
1 change: 0 additions & 1 deletion buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ dependencies {

// Dependencies used to configure the gradle plugins
implementation(embeddedKotlin("gradle-plugin"))
implementation(libs.detektPluginGradle)
implementation(libs.androidToolsPluginGradle)
implementation(libs.versionsPluginGradle)
implementation(libs.fuzzyWuzzy)
Expand Down

This file was deleted.

4 changes: 0 additions & 4 deletions dd-sdk-android-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import com.datadog.gradle.config.MavenConfig
import com.datadog.gradle.config.dependencyUpdateConfig
import com.datadog.gradle.config.detektConfig
import com.datadog.gradle.config.jacocoConfig
import com.datadog.gradle.config.javadocConfig
import com.datadog.gradle.config.junitConfig
Expand All @@ -26,7 +25,6 @@ plugins {

// Analysis tools
id("com.github.ben-manes.versions")
id("io.gitlab.arturbosch.detekt")

// Tests
jacoco
Expand All @@ -48,11 +46,9 @@ dependencies {
testImplementation(libs.okHttpMock)
testImplementation(libs.androidToolsPluginGradle)
testImplementation(libs.kotlinPluginGradle)
detekt(libs.detektCli)
}

kotlinConfig()
detektConfig()
junitConfig()
jacocoConfig()
javadocConfig()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1346,8 +1346,8 @@ internal class DdAndroidGradlePluginFunctionalTest {
}
""".trimIndent()

const val LATEST_GRADLE_VERSION = "8.6"
const val LATEST_AGP_VERSION = "8.3.2"
const val LATEST_GRADLE_VERSION = "8.7"
const val LATEST_AGP_VERSION = "8.4.0"

// NB: starting from AGP 7.x, Gradle should have the same major version.
// While work with Gradle with higher major version is possible, it is not guaranteed.
Expand Down
Loading
Loading