Merge pull request #2018 from DataDog/nogorodnikov/rum-4359/add-statu…

…s-code-in-unknown-error-log-message RUM-4359: Add status code in user-facing message in case of `UnknownError` during batch upload
DataDog · May 2, 2024 · d9e9cad · d9e9cad
2 parents 2adb85c + 6d10b15
commit d9e9cad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ndroid-core/src/main/kotlin/com/datadog/android/core/internal/data/upload/UploadStatus.kt b/...ndroid-core/src/main/kotlin/com/datadog/android/core/internal/data/upload/UploadStatus.kt
@@ -86,7 +86,7 @@ internal sealed class UploadStatus(val shouldRetry: Boolean = false, val code: I
             is UnknownError -> logger.log(
                 InternalLogger.Level.ERROR,
                 InternalLogger.Target.USER,
-                { "$batchInfo failed because of an unknown error; the batch was dropped." }
+                { "$batchInfo failed because of an unknown error (status code = $code); the batch was dropped." }
             )
 
             is RequestCreationError -> logger.log(

diff --git a/...id-core/src/test/kotlin/com/datadog/android/core/internal/data/upload/UploadStatusTest.kt b/...id-core/src/test/kotlin/com/datadog/android/core/internal/data/upload/UploadStatusTest.kt
@@ -209,7 +209,7 @@ internal class UploadStatusTest {
             InternalLogger.Level.ERROR,
             InternalLogger.Target.USER,
             "Batch [$fakeByteSize bytes] ($fakeContext) failed " +
-                "because of an unknown error; the batch was dropped."
+                "because of an unknown error (status code = ${status.code}); the batch was dropped."
         )
     }