Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2385 Intercept window touch events as Session Replay TouchData #1009

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2385/session-replay-record-screen-interactions-as-touch-data branch from 89e0151 to beffd24 Compare August 8, 2022 16:25
@xgouchet xgouchet added the size-medium This PR is medium sized label Aug 8, 2022
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2356/add-session-replay-recorder-logic branch from d9065f3 to 29b0cdd Compare August 8, 2022 17:15
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2385/session-replay-record-screen-interactions-as-touch-data branch 2 times, most recently from d28205f to e82d873 Compare August 9, 2022 07:42
@mariusc83 mariusc83 marked this pull request as ready for review August 9, 2022 07:43
@mariusc83 mariusc83 requested a review from a team as a code owner August 9, 2022 07:43
@mariusc83 mariusc83 self-assigned this Aug 9, 2022
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2385/session-replay-record-screen-interactions-as-touch-data branch 2 times, most recently from b7562c5 to 13a90bc Compare August 11, 2022 07:59
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2356/add-session-replay-recorder-logic branch from 25061da to c1c8cba Compare August 17, 2022 08:16
Base automatically changed from mconstantin/rumm-2356/add-session-replay-recorder-logic to feature/session-replay-vo August 17, 2022 08:33
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2385/session-replay-record-screen-interactions-as-touch-data branch from 13a90bc to af0db01 Compare August 17, 2022 08:46
@codecov-commenter
Copy link

Codecov Report

Merging #1009 (af0db01) into feature/session-replay-vo (922fd29) will increase coverage by 0.10%.
The diff coverage is 87.25%.

@@                      Coverage Diff                      @@
##           feature/session-replay-vo    #1009      +/-   ##
=============================================================
+ Coverage                      82.99%   83.09%   +0.10%     
=============================================================
  Files                            307      316       +9     
  Lines                           9980    10181     +201     
  Branches                        1628     1675      +47     
=============================================================
+ Hits                            8282     8459     +177     
- Misses                          1193     1196       +3     
- Partials                         505      526      +21     
Impacted Files Coverage Δ
...nal/tracking/AndroidXFragmentLifecycleCallbacks.kt 93.48% <ø> (ø)
...droid/sessionreplay/processor/SnapshotProcessor.kt 100.00% <ø> (ø)
...m/datadog/android/sessionreplay/recorder/IntExt.kt 100.00% <ø> (ø)
...com/datadog/android/sessionreplay/recorder/Node.kt 66.67% <66.67%> (+66.67%) ⬆️
...ionreplay/recorder/mapper/ButtonWireframeMapper.kt 66.67% <66.67%> (ø)
...android/sessionreplay/recorder/SnapshotProducer.kt 77.14% <77.14%> (+27.14%) ⬆️
...y/recorder/mapper/ViewScreenshotWireframeMapper.kt 80.00% <80.00%> (ø)
...onreplay/recorder/mapper/GenericWireframeMapper.kt 85.71% <85.71%> (ø)
...ssionreplay/recorder/mapper/ViewWireframeMapper.kt 88.46% <88.46%> (ø)
...ssionreplay/recorder/mapper/TextWireframeMapper.kt 89.66% <89.66%> (ø)
... and 12 more

@mariusc83 mariusc83 merged commit 48e737c into feature/session-replay-vo Aug 17, 2022
@mariusc83 mariusc83 deleted the mconstantin/rumm-2385/session-replay-record-screen-interactions-as-touch-data branch August 17, 2022 09:09
@xgouchet xgouchet added this to the internal milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants