Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2501: Use SDK v2 components in the upload pipeline #1040

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Sep 14, 2022

What does this PR do?

This is a transitional PR (some things are not final) which makes the usage of SDK v2 components in the upload pipeline.

Namely we now are using Storage for the batch reads and RequestFactory as well.

Some content inside the implementations of RequestFactory for RUM, Logs and Traces is duplicated, but this is on purpose, because later on these classes will be split into different modules.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner September 14, 2022 09:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1040 (cac35df) into feature/sdkv2 (b4c813b) will decrease coverage by 0.03%.
The diff coverage is 85.58%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1040      +/-   ##
=================================================
- Coverage          82.89%   82.86%   -0.03%     
=================================================
  Files                301      306       +5     
  Lines               9951    10080     +129     
  Branches            1637     1642       +5     
=================================================
+ Hits                8248     8352     +104     
- Misses              1207     1229      +22     
- Partials             496      499       +3     
Impacted Files Coverage Δ
...otlin/com/datadog/android/v2/api/RequestFactory.kt 0.00% <0.00%> (ø)
...id/v2/core/internal/storage/ConsentAwareStorage.kt 96.81% <ø> (ø)
...atadog/android/v2/core/internal/storage/Storage.kt 0.00% <ø> (ø)
...og/android/v2/core/internal/NoOpContextProvider.kt 4.35% <4.35%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 64.00% <33.33%> (-1.60%) ⬇️
...adog/android/error/internal/CrashReportsFeature.kt 96.67% <66.67%> (-0.56%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 91.67% <66.67%> (-2.78%) ⬇️
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.67% <66.67%> (-0.49%) ⬇️
...datadog/android/tracing/internal/TracingFeature.kt 92.86% <66.67%> (-1.88%) ⬇️
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <83.33%> (-1.00%) ⬇️
... and 22 more

@xgouchet xgouchet added the size-large This PR is large sized label Sep 14, 2022
@0xnm 0xnm force-pushed the nogorodnikov/rumm-2501/use-sdkv2-components-in-upload-pipeline branch from cac35df to 2831cc9 Compare September 20, 2022 07:35
@0xnm 0xnm merged commit f913074 into feature/sdkv2 Sep 20, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2501/use-sdkv2-components-in-upload-pipeline branch September 20, 2022 07:57
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-large This PR is large sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants