Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Data Collected Edits #1059

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Android Data Collected Edits #1059

merged 1 commit into from
Sep 27, 2022

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Sep 27, 2022

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

Hotjar

Additional Notes

Addresses some copy nits flagged by translators.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@alai97 alai97 requested review from a team as code owners September 27, 2022 21:11
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov-commenter
Copy link

Codecov Report

Merging #1059 (8b61e1e) into master (00c4fc5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   83.16%   83.16%   +0.01%     
==========================================
  Files         272      272              
  Lines        9280     9295      +15     
  Branches     1493     1500       +7     
==========================================
+ Hits         7717     7730      +13     
- Misses       1153     1154       +1     
- Partials      410      411       +1     
Impacted Files Coverage Δ
...n/kotlin/com/datadog/android/timber/DatadogTree.kt 50.00% <0.00%> (-5.56%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 86.54% <0.00%> (-1.92%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.86% <0.00%> (-0.60%) ⬇️
...main/kotlin/com/datadog/android/rx/DatadogRxExt.kt 100.00% <0.00%> (ø)
...tadog/android/fresco/DatadogFrescoCacheListener.kt 100.00% <0.00%> (ø)
...kotlin/com/datadog/android/DatadogEventListener.kt 98.51% <0.00%> (+0.02%) ⬆️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 96.03% <0.00%> (+0.06%) ⬆️
.../android/rum/internal/tracking/ViewLoadingTimer.kt 93.55% <0.00%> (+0.22%) ⬆️
.../datadog/android/rum/webview/RumWebChromeClient.kt 81.48% <0.00%> (+0.71%) ⬆️
...tadog/android/tv/LeanbackViewAttributesProvider.kt 86.21% <0.00%> (+2.00%) ⬆️
... and 1 more

@alai97 alai97 merged commit 35dfa36 into master Sep 27, 2022
@alai97 alai97 deleted the alai97/noticed-some-typos branch September 27, 2022 22:29
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants