Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2563: Create storage and uploader outside of the feature #1070

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 5, 2022

What does this PR do?

Storage and DataUploader are pulled outside of the feature-specific classes, because core module will be responsible for those two.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner October 5, 2022 11:27
@xgouchet xgouchet added the size-medium This PR is medium sized label Oct 5, 2022
@0xnm 0xnm force-pushed the nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature branch from 4051a19 to 86e2a3f Compare October 5, 2022 12:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1070 (86e2a3f) into feature/sdkv2 (f5dd448) will increase coverage by 0.20%.
The diff coverage is 93.14%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1070      +/-   ##
=================================================
+ Coverage          82.96%   83.16%   +0.20%     
=================================================
  Files                306      306              
  Lines              10158    10176      +18     
  Branches            1658     1649       -9     
=================================================
+ Hits                8427     8462      +35     
+ Misses              1219     1213       -6     
+ Partials             512      501      -11     
Impacted Files Coverage Δ
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 80.65% <88.71%> (+9.22%) ⬆️
...in/com/datadog/android/core/internal/SdkFeature.kt 91.23% <100.00%> (-0.84%) ⬇️
...istence/file/batch/BatchFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...ror/internal/CrashReportFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...adog/android/error/internal/CrashReportsFeature.kt 96.77% <100.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 92.31% <100.00%> (ø)
.../log/internal/domain/LogFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.75% <100.00%> (ø)
.../rum/internal/domain/RumFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...datadog/android/tracing/internal/TracingFeature.kt 93.33% <100.00%> (ø)
... and 13 more

@0xnm 0xnm merged commit 3917047 into feature/sdkv2 Oct 6, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature branch October 6, 2022 12:53
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants