RUMM-2568: Remove DataReader v1 usages

[0xnm]

What does this PR do?

Remove the remaining usages of DataReader used in v1, because we are now using Storage for reading raw data and de-serialization is not needed anyway.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Make sure you discussed the feature or bugfix with the maintaining team in an Issue
• Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

[codecov-commenter]

Codecov Report

Merging #1071 (4051a19) into nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature (86e2a3f) will increase coverage by 0.04%.
The diff coverage is 92.86%.

@@                                              Coverage Diff                                              @@
##           nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature    #1071      +/-   ##
=============================================================================================================
+ Coverage                                                                      83.16%   83.20%   +0.04%     
=============================================================================================================
  Files                                                                            306      306              
  Lines                                                                          10176    10173       -3     
  Branches                                                                        1649     1649              
=============================================================================================================
+ Hits                                                                            8462     8464       +2     
+ Misses                                                                          1213     1209       -4     
+ Partials                                                                         501      500       -1     

Impacted Files	Coverage Δ
...istence/file/batch/BatchFilePersistenceStrategy.kt	100.00% <ø> (ø)
...ror/internal/CrashReportFilePersistenceStrategy.kt	100.00% <ø> (ø)
.../log/internal/domain/LogFilePersistenceStrategy.kt	100.00% <ø> (ø)
.../rum/internal/domain/RumFilePersistenceStrategy.kt	100.00% <ø> (ø)
...g/internal/domain/TracesFilePersistenceStrategy.kt	100.00% <ø> (ø)
...atadog/android/v2/core/internal/storage/Storage.kt	0.00% <ø> (ø)
.../internal/log/WebViewLogFilePersistenceStrategy.kt	100.00% <ø> (ø)
.../internal/rum/WebViewRumFilePersistenceStrategy.kt	64.29% <ø> (-1.23%)	⬇️
...id/v2/core/internal/storage/ConsentAwareStorage.kt	97.09% <92.31%> (+0.31%)	⬆️
...in/com/datadog/android/core/internal/SdkFeature.kt	91.23% <100.00%> (ø)
... and 7 more

[mariusc83]

I am not seeing where you assert the removed locked batches...am I missing something ?

[0xnm]

that is true, there is no assertion of this internal state. We just rely that file was removed.

To assert this we need to make lockedBatches field internal and Batch class as well.

[xgouchet]

LGTM