Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Session Replay branch into SDK v2 branch #1075

Merged
merged 30 commits into from
Oct 7, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 6, 2022

What does this PR do?

This PR does a merge of feature/session-replay-v0 branch into feature/sdkv2 branch with all the issues resolved.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner October 6, 2022 15:45
@0xnm 0xnm requested a review from a team as a code owner October 6, 2022 15:45
Copy link
Collaborator

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm 0xnm force-pushed the nogorodnikov/merge-sr-into-sdk-v2 branch from 652ed63 to 56890c3 Compare October 6, 2022 15:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #1075 (56890c3) into feature/sdkv2 (3917047) will decrease coverage by 0.69%.
The diff coverage is 77.13%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1075      +/-   ##
=================================================
- Coverage          83.16%   82.46%   -0.69%     
=================================================
  Files                306      347      +41     
  Lines              10176    11194    +1018     
  Branches            1649     1844     +195     
=================================================
+ Hits                8462     9231     +769     
- Misses              1213     1382     +169     
- Partials             501      581      +80     
Impacted Files Coverage Δ
...main/kotlin/com/datadog/android/DatadogEndpoint.kt 0.00% <ø> (ø)
...istence/file/batch/BatchFilePersistenceStrategy.kt 100.00% <ø> (ø)
...ror/internal/CrashReportFilePersistenceStrategy.kt 100.00% <ø> (ø)
.../log/internal/domain/LogFilePersistenceStrategy.kt 100.00% <ø> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.75% <ø> (ø)
.../rum/internal/domain/RumFilePersistenceStrategy.kt 100.00% <ø> (ø)
...nal/tracking/AndroidXFragmentLifecycleCallbacks.kt 93.48% <ø> (ø)
...g/internal/domain/TracesFilePersistenceStrategy.kt 100.00% <ø> (ø)
...og/android/v2/core/internal/NoOpContextProvider.kt 4.35% <ø> (ø)
...atadog/android/v2/core/internal/storage/Storage.kt 0.00% <ø> (ø)
... and 67 more

@xgouchet xgouchet added the size-huge This PR is huge sized label Oct 6, 2022
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review necessary 👍

@0xnm 0xnm merged commit 451d0cd into feature/sdkv2 Oct 7, 2022
@0xnm 0xnm deleted the nogorodnikov/merge-sr-into-sdk-v2 branch October 7, 2022 07:56
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-huge This PR is huge sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants