-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Session Replay branch into SDK v2 branch #1075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xnm
force-pushed
the
nogorodnikov/merge-sr-into-sdk-v2
branch
from
October 6, 2022 15:56
652ed63
to
56890c3
Compare
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1075 +/- ##
=================================================
- Coverage 83.16% 82.46% -0.69%
=================================================
Files 306 347 +41
Lines 10176 11194 +1018
Branches 1649 1844 +195
=================================================
+ Hits 8462 9231 +769
- Misses 1213 1382 +169
- Partials 501 581 +80
|
cswatt
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no docs review necessary 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does a merge of
feature/session-replay-v0
branch intofeature/sdkv2
branch with all the issues resolved.Review checklist (to be filled by reviewers)