Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package from AndroidManifest to namespace plugin config property for Session Replay module #1095

Merged

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 19, 2022

What does this PR do?

With AGP 7.3.0 package property in AndroidManifest is obsolete, namespace property in the AGP configuration should be used instead.

Since AndroidManfest is empty after the removal, it is deleted.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner October 19, 2022 12:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1095 (8bcd8fc) into feature/sdkv2 (cabffad) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1095      +/-   ##
=================================================
- Coverage          82.66%   82.62%   -0.04%     
=================================================
  Files                349      349              
  Lines              11229    11229              
  Branches            1838     1838              
=================================================
- Hits                9282     9277       -5     
- Misses              1388     1393       +5     
  Partials             559      559              
Impacted Files Coverage Δ
...src/main/kotlin/com/datadog/android/DatadogSite.kt 83.33% <0.00%> (-3.33%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-1.96%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.84%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 82.81% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.36% <0.00%> (+0.53%) ⬆️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 91.94% <0.00%> (+1.61%) ⬆️

Base automatically changed from nogorodnikov/rumm-2672/make-storage-writecurrentbatch-async to feature/sdkv2 October 20, 2022 08:44
@0xnm 0xnm merged commit a64e520 into feature/sdkv2 Oct 21, 2022
@0xnm 0xnm deleted the nogorodnikov/remove-androidmanifest-for-session-replay branch October 21, 2022 07:00
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants