-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2496 SR Correctly handle clipped elements and scrollable lists #1101
Merged
mariusc83
merged 2 commits into
feature/sdkv2
from
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
Oct 26, 2022
Merged
RUMM-2496 SR Correctly handle clipped elements and scrollable lists #1101
mariusc83
merged 2 commits into
feature/sdkv2
from
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
3 times, most recently
from
October 24, 2022 13:47
1e56f89
to
2f869d3
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
from
October 24, 2022 14:05
2f869d3
to
346ba51
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
3 times, most recently
from
October 24, 2022 14:59
c9cba70
to
7dfe501
Compare
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1101 +/- ##
=================================================
+ Coverage 82.53% 82.60% +0.07%
=================================================
Files 347 350 +3
Lines 11183 11244 +61
Branches 1834 1851 +17
=================================================
+ Hits 9229 9287 +58
- Misses 1391 1399 +8
+ Partials 563 558 -5
|
0xnm
reviewed
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great (and big!). I've left some questions/comments.
...sion-replay/src/main/kotlin/com/datadog/android/sessionreplay/processor/SnapshotProcessor.kt
Show resolved
Hide resolved
...session-replay/src/main/kotlin/com/datadog/android/sessionreplay/processor/WireframeUtils.kt
Show resolved
Hide resolved
...ssion-replay/src/test/kotlin/com/datadog/android/sessionreplay/utils/BoundsForgeryFactory.kt
Outdated
Show resolved
Hide resolved
...session-replay/src/test/kotlin/com/datadog/android/sessionreplay/utils/NodeForgeryFactory.kt
Outdated
Show resolved
Hide resolved
...sion-replay/src/test/kotlin/com/datadog/android/sessionreplay/processor/NodeFlattenerTest.kt
Show resolved
Hide resolved
...d-session-replay/src/test/kotlin/com/datadog/android/sessionreplay/recorder/ViewUtilsTest.kt
Outdated
Show resolved
Hide resolved
...d-session-replay/src/test/kotlin/com/datadog/android/sessionreplay/recorder/ViewUtilsTest.kt
Outdated
Show resolved
Hide resolved
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
from
October 25, 2022 13:59
7dfe501
to
aacb470
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
from
October 25, 2022 14:02
aacb470
to
b6e3d2e
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
from
October 25, 2022 14:19
b6e3d2e
to
0edde83
Compare
0xnm
approved these changes
Oct 26, 2022
mariusc83
deleted the
mconstantin/rumm-2496/correctly-handle-the-scrollable-lists
branch
October 26, 2022 15:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are introducing the capability of the SR recorder to add the clipping property to each
Wireframe
whenever it is outside of any of its parents bounds. The following updates where added:WireframeClip
optional property was added into theWireframe
andWireframeUpdate
SR schemasNode
Nodes
into aList<Wireframe>
we keep track of the parents for each of theWireframe
and we are computing theWireframeClip
property. This will solve also the issue when aWireframe
is rendered inside aScrollableList
Wireframe
we take into account also theclipping
dimensionsMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)