Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2682: Use event write context for Session Replay #1107

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 26, 2022

What does this PR do?

This PR brings the usage of event write context (which can be retrieved by calling withWriteContext) for Session Replay.

There are places where context is not completely used (like GlobalRum access or server time offset), but they will be addressed later, they have a dependency on some changes in RUM.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner October 26, 2022 15:53
@0xnm 0xnm force-pushed the nogorodnikov/rumm-2682/use-event-write-context-for-session-replay branch from 3e79f86 to 3c3b040 Compare October 26, 2022 16:05
@xgouchet xgouchet added the size-small This PR is small sized label Oct 26, 2022
@0xnm 0xnm force-pushed the nogorodnikov/rumm-2607/use-eventwritecontext-for-logs branch from cd86390 to 169cbec Compare October 27, 2022 11:44
Base automatically changed from nogorodnikov/rumm-2607/use-eventwritecontext-for-logs to feature/sdkv2 October 27, 2022 12:36
@codecov-commenter
Copy link

Codecov Report

Merging #1107 (3c3b040) into feature/sdkv2 (9b73f57) will decrease coverage by 0.33%.
The diff coverage is 88.51%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1107      +/-   ##
=================================================
- Coverage          82.69%   82.36%   -0.33%     
=================================================
  Files                350      350              
  Lines              11301    11355      +54     
  Branches            1846     1875      +29     
=================================================
+ Hits                9345     9352       +7     
- Misses              1394     1433      +39     
- Partials             562      570       +8     
Impacted Files Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 91.09% <ø> (-0.35%) ⬇️
...in/com/datadog/android/core/internal/SdkFeature.kt 88.18% <ø> (ø)
...atadog/android/log/internal/domain/LogGenerator.kt 80.00% <ø> (-3.33%) ⬇️
...og/android/v2/core/internal/NoOpContextProvider.kt 3.57% <0.00%> (-0.78%) ⬇️
...play/internal/storage/SessionReplayRecordWriter.kt 16.67% <16.67%> (ø)
.../android/v2/log/internal/storage/LogsDataWriter.kt 60.00% <60.00%> (ø)
.../android/error/internal/DatadogExceptionHandler.kt 81.08% <84.62%> (-4.63%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 87.10% <85.96%> (-12.90%) ⬇️
...g/android/log/internal/logger/DatadogLogHandler.kt 90.91% <86.96%> (-0.76%) ⬇️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 94.02% <93.33%> (+0.12%) ⬆️
... and 25 more

@0xnm 0xnm force-pushed the nogorodnikov/rumm-2682/use-event-write-context-for-session-replay branch from 3c3b040 to 3cd9096 Compare October 27, 2022 13:24
@0xnm 0xnm merged commit ede9312 into feature/sdkv2 Oct 27, 2022
@0xnm 0xnm deleted the nogorodnikov/rumm-2682/use-event-write-context-for-session-replay branch October 27, 2022 13:45
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small This PR is small sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants