Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source key in SR upload form #1109

Merged

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 requested a review from a team as a code owner October 27, 2022 09:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #1109 (c421de4) into mconstantin/rumm-2689/sr-flush-touch-positions-every-n-milliseconds (18ad05c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@                                           Coverage Diff                                           @@
##           mconstantin/rumm-2689/sr-flush-touch-positions-every-n-milliseconds    #1109      +/-   ##
=======================================================================================================
+ Coverage                                                                82.77%   82.79%   +0.02%     
=======================================================================================================
  Files                                                                      352      352              
  Lines                                                                    11366    11366              
  Branches                                                                  1865     1865              
=======================================================================================================
+ Hits                                                                      9408     9410       +2     
+ Misses                                                                    1397     1396       -1     
+ Partials                                                                   561      560       -1     
Impacted Files Coverage Δ
...replay/internal/net/SessionReplayOkHttpUploader.kt 5.26% <ø> (ø)
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 82.81% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.83% <0.00%> (+1.06%) ⬆️

Base automatically changed from mconstantin/rumm-2689/sr-flush-touch-positions-every-n-milliseconds to feature/sdkv2 October 28, 2022 07:33
@mariusc83 mariusc83 merged commit 5b51d1d into feature/sdkv2 Oct 28, 2022
@mariusc83 mariusc83 deleted the mconstantin/fix-source-key-in-sr-upload-form branch October 28, 2022 08:09
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants