RUMM-2685 Start/Stop Session recording based on the RUM session state #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rumm-2685/pause-resume-session-replay-based-on-rum-context
branch
from
830ffab
to
2a00173
Compare
0xnm
approved these changes
Nov 3, 2022
| @BeforeEach | ||
| fun `set up`(forge: Forge) { | ||
| fakeInitialViewEvent = forge.startViewEvent() | ||
|
|
||
| whenever(mockParentScope.getRumContext()) doReturn fakeParentContext | ||
| whenever(mockChildScope.handleEvent(any(), any())) doReturn mockChildScope | ||
| whenever(mockSdkCore.getFeature(RumSessionScope.SESSION_REPLAY_FEATURE_NAME)) | ||
| .thenReturn(mockSessionReplayFeatureScope) |
There was a problem hiding this comment.
minor suggestion, just for the consistency
Suggested change
| .thenReturn(mockSessionReplayFeatureScope) | |
| doReturn mockSessionReplayFeatureScope |
mariusc83
force-pushed
the
mconstantin/rumm-2685/pause-resume-session-replay-based-on-rum-context
branch
2 times, most recently
from
ab2dea9
to
bf2b68c
Compare
xgouchet
approved these changes
Nov 4, 2022
mariusc83
force-pushed
the
mconstantin/rumm-2685/pause-resume-session-replay-based-on-rum-context
branch
from
bf2b68c
to
986a16a
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2685/pause-resume-session-replay-based-on-rum-context
branch
from
986a16a
to
5a7e28b
Compare
mariusc83
deleted the
mconstantin/rumm-2685/pause-resume-session-replay-based-on-rum-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are making sure that the Session recording is being stopped/resumed according with the RUM session state: tracked or not tracked.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)