Add telemetry configuration mapper #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow cross platform SDKs to modify the configuration before sending it to telemetry.
fuzzybinary
force-pushed
the
jward/RUMM-2733-telemetry-configuration-mapper
branch
from
bdaa6a4
to
6093e33
Compare
xgouchet
approved these changes
Nov 14, 2022
0xnm
approved these changes
Nov 14, 2022
fuzzybinary
deleted the
jward/RUMM-2733-telemetry-configuration-mapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will allow cross platform SDKs to modify the configuration before sending it to telemetry.
The actual function on
Configuration.Builderis internal, and exposed through the companion object on_InternalTelemetryto make it obvious this is meant as an internal mechanism.Additional Notes
Currently, this method is useless because none of the properties on
TelemetryConfigurationEventare mutable, but a PR is up modify the schema to fix that.Review checklist (to be filled by reviewers)