Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2765 Fix unit tests flakiness in MutationResolverTest #1157

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 requested a review from a team as a code owner November 24, 2022 14:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #1157 (01d9eb5) into feature/sdkv2 (d451d7e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1157      +/-   ##
=================================================
+ Coverage          82.28%   82.29%   +0.01%     
=================================================
  Files                353      353              
  Lines              11796    11796              
  Branches            2007     2007              
=================================================
+ Hits                9706     9707       +1     
- Misses              1465     1466       +1     
+ Partials             625      623       -2     
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 71.43% <0.00%> (-28.57%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.67% <0.00%> (-0.83%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.78% <0.00%> (-0.56%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 89.66% <0.00%> (+0.43%) ⬆️
...android/log/internal/domain/DatadogLogGenerator.kt 95.95% <0.00%> (+0.68%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (+3.23%) ⬆️
... and 1 more

@mariusc83 mariusc83 force-pushed the mconstantin/rumm-2765/fix-flaky-tests-in-MutationResolver branch from 1fedf7e to 01d9eb5 Compare November 24, 2022 15:15
@mariusc83 mariusc83 merged commit 32afedf into feature/sdkv2 Nov 25, 2022
@mariusc83 mariusc83 deleted the mconstantin/rumm-2765/fix-flaky-tests-in-MutationResolver branch November 25, 2022 08:19
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants