Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2752: Prepare merge of SDK v2 branch into develop branch #1158

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 25, 2022

What does this PR do?

This PR does some preparations before the merge of SDK v2 branch into develop branch:

  • Configuration.Builder#setSecurityConfig is renamed to setEncryption to be on-par with iOS SDK API, SecurityConfig object is removed.
  • Session Replay public APIs are removed. This change will be reverted later for the SDK v2 branch, it is needed only for the merge to the develop.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 25, 2022 08:46
@xgouchet xgouchet added the size-medium This PR is medium sized label Nov 25, 2022
@0xnm 0xnm merged commit 8d6e9c5 into feature/sdkv2 Nov 25, 2022
@0xnm 0xnm deleted the nogorodnikov/prepare-merge-sdkv2-into-develop branch November 25, 2022 09:19
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium This PR is medium sized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants