Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nightly tests flakiness #1165

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 29, 2022

What does this PR do?

This change fixes some flakiness in our tests:

  • Some tests rely on the action.name assertion, but in case of action.type=back there is no action.name, only action.target.name. So we need to exclude back action type from such tests.
  • With ♻️ [RUMF-1368] use the PointerDown event target for click actions browser-sdk#1731 browser-sdk requires an element to have pointerdown event before the actual click to register RUM action. The change is done instrumented test to add the necessary event.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 29, 2022 13:53
@0xnm 0xnm merged commit 95f8b91 into develop Nov 29, 2022
@0xnm 0xnm deleted the nogorodnikov/fix-some-nightly-tests-flakiness branch November 29, 2022 14:24
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants