Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TLV format reader test #1166

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 29, 2022

What does this PR do?

This change fixes flaky test - it was allowing to generate the value of block type which is perfectly correct instead of incorrect.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 29, 2022 14:25
@codecov-commenter
Copy link

Codecov Report

Merging #1166 (92f6ae4) into develop (9eb9417) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1166      +/-   ##
===========================================
+ Coverage    82.26%   82.29%   +0.03%     
===========================================
  Files          353      353              
  Lines        11775    11775              
  Branches      2005     2005              
===========================================
+ Hits          9686     9690       +4     
- Misses        1473     1475       +2     
+ Partials       616      610       -6     
Impacted Files Coverage Δ
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-1.96%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.67% <0.00%> (-0.83%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 84.62% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 95.42% <0.00%> (+0.37%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (+0.86%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.68% <0.00%> (+1.48%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+14.29%) ⬆️

@0xnm 0xnm merged commit b4ea30b into develop Nov 29, 2022
@0xnm 0xnm deleted the nogorodnikov/fix-flaky-tlv-format-reader-test branch November 29, 2022 15:54
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants