Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to setup facets and measures #1179

Merged

Conversation

louiszawadzki
Copy link
Contributor

@louiszawadzki louiszawadzki commented Dec 8, 2022

What does this PR do?

Fix broken link in documentation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@louiszawadzki louiszawadzki requested review from a team as code owners December 8, 2022 14:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #1179 (ad5bd52) into master (d2caeca) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   83.19%   83.06%   -0.13%     
==========================================
  Files         274      274              
  Lines        9458     9458              
  Branches     1540     1540              
==========================================
- Hits         7868     7856      -12     
- Misses       1153     1156       +3     
- Partials      437      446       +9     
Impacted Files Coverage Δ
...main/java/com/datadog/exec/CommonTaskExecutor.java 45.83% <0.00%> (-4.17%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 96.15% <0.00%> (-3.85%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 68.75% <0.00%> (-3.57%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 85.41% <0.00%> (-3.24%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.78% <0.00%> (-0.56%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (+0.42%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 90.00% <0.00%> (+10.00%) ⬆️

@jtappa jtappa merged commit 1b66a63 into master Dec 8, 2022
@jtappa jtappa deleted the louiszawadzki/fix-docs-link-to-setup-facets-and-measures branch December 8, 2022 22:30
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants