Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTG-8 Apply new detekt configuration #1180

Merged
merged 15 commits into from
Dec 12, 2022
Merged

MTG-8 Apply new detekt configuration #1180

merged 15 commits into from
Dec 12, 2022

Conversation

xgouchet
Copy link
Collaborator

@xgouchet xgouchet commented Dec 8, 2022

What does this PR do?

Use the shared static analysis job with an updated detekt configuration

@xgouchet xgouchet requested a review from a team as a code owner December 8, 2022 15:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #1180 (32a07a0) into develop (67e6ba4) will decrease coverage by 0.04%.
The diff coverage is 87.27%.

❗ Current head 32a07a0 differs from pull request most recent head be1bce6. Consider uploading reports for the commit be1bce6 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1180      +/-   ##
===========================================
- Coverage    82.31%   82.26%   -0.04%     
===========================================
  Files          353      353              
  Lines        11778    11790      +12     
  Branches      2006     2005       -1     
===========================================
+ Hits          9694     9699       +5     
- Misses        1470     1475       +5     
- Partials       614      616       +2     
Impacted Files Coverage Δ
.../com/datadog/android/ktx/coroutine/CoroutineExt.kt 75.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/rum/ClosableExt.kt 100.00% <ø> (ø)
...om/datadog/android/ktx/sqlite/SqliteDatabaseExt.kt 92.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/tracing/SpanExt.kt 86.67% <ø> (-1.57%) ⬇️
...in/com/datadog/android/sqldelight/SqlDelightExt.kt 80.65% <ø> (ø)
...rnal/persistence/file/EncryptedFileReaderWriter.kt 93.75% <ø> (ø)
...ndroid/core/internal/persistence/file/FileMover.kt 62.96% <ø> (ø)
...rnal/persistence/file/batch/BatchFileDataWriter.kt 88.24% <ø> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 88.24% <ø> (+1.96%) ⬆️
...al/persistence/file/single/SingleItemDataWriter.kt 95.83% <ø> (ø)
... and 76 more

buildSrc/src/test/kotlin/com/example/model/Version.kt Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xgouchet xgouchet merged commit 2dffc83 into develop Dec 12, 2022
@xgouchet xgouchet deleted the xgouchet/MTG-8/detekt branch December 12, 2022 15:02
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants