RUMM-2780: Synchronize access to DatadogRumMonitor#rootScope when processing fatal error #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rumm-2780/synchronize-access-to-root-scope-when-processing-fatal-error
branch
from
1359f0a
to
8516f72
Compare
0xnm
changed the title
mariusc83
reviewed
Dec 9, 2022
...dk-android/src/test/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitorTest.kt
Show resolved
Hide resolved
mariusc83
approved these changes
Dec 9, 2022
…cessing fatal error
0xnm
force-pushed
the
nogorodnikov/rumm-2780/synchronize-access-to-root-scope-when-processing-fatal-error
branch
from
8516f72
to
a845e60
Compare
xgouchet
approved these changes
Dec 12, 2022
0xnm
deleted the
nogorodnikov/rumm-2780/synchronize-access-to-root-scope-when-processing-fatal-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1178. When processing fatal error
rootScopeshould be synchronized as well, as for the normal flow.Otherwise 2 threads may enter
RumScopesimultaneously, leading to the different bugs likeConcurrentModificationException.Review checklist (to be filled by reviewers)