-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in CONTRIBUTING.md #1188
Fix typo in CONTRIBUTING.md #1188
Conversation
CONTRIBUTING.md
Outdated
detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-common.yml --excludes "**/model/*.kt,**/build/**" | ||
detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-public-api.yml --excludes "**/model/*.kt,**/build/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use --excludes "**/build/**"
as I have a PR moving the generated files into the build
folder, and I'm gonna change the shared config to ignore those folders anyway
This should not be needed after #1189 and ddsource#20537 are merged |
54c6652
to
111bbde
Compare
@xgouchet good to know! let's keep the part with typo fix then, I updated and renamed this PR. |
Codecov Report
@@ Coverage Diff @@
## develop #1188 +/- ##
===========================================
+ Coverage 82.27% 82.30% +0.03%
===========================================
Files 353 353
Lines 11793 11793
Branches 2006 2006
===========================================
+ Hits 9702 9706 +4
+ Misses 1477 1476 -1
+ Partials 614 611 -3
|
What does this PR do?
This change fixes a typo in
CONTRIBUTING.md
file.Review checklist (to be filled by reviewers)