Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING.md #1188

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Dec 12, 2022

What does this PR do?

This change fixes a typo in CONTRIBUTING.md file.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner December 12, 2022 16:01
CONTRIBUTING.md Outdated
Comment on lines 52 to 53
detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-common.yml --excludes "**/model/*.kt,**/build/**"
detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-public-api.yml --excludes "**/model/*.kt,**/build/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use --excludes "**/build/**" as I have a PR moving the generated files into the build folder, and I'm gonna change the shared config to ignore those folders anyway

@xgouchet
Copy link
Collaborator

This should not be needed after #1189 and ddsource#20537 are merged

@0xnm 0xnm force-pushed the nogorodnikov/exclude-generated-files-from-detekt-run branch from 54c6652 to 111bbde Compare December 13, 2022 08:22
@0xnm 0xnm changed the title Exclude generated files from detekt run Fix typo in CONTRIBUTING.md Dec 13, 2022
@0xnm
Copy link
Contributor Author

0xnm commented Dec 13, 2022

@xgouchet good to know! let's keep the part with typo fix then, I updated and renamed this PR.

@codecov-commenter
Copy link

Codecov Report

Merging #1188 (111bbde) into develop (b627277) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1188      +/-   ##
===========================================
+ Coverage    82.27%   82.30%   +0.03%     
===========================================
  Files          353      353              
  Lines        11793    11793              
  Branches      2006     2006              
===========================================
+ Hits          9702     9706       +4     
+ Misses        1477     1476       -1     
+ Partials       614      611       -3     
Impacted Files Coverage Δ
.../src/main/java/com/datadog/opentracing/DDSpan.java 40.66% <0.00%> (-1.10%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.19% <0.00%> (-0.49%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (+1.61%) ⬆️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.27% <0.00%> (+2.52%) ⬆️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 92.31% <0.00%> (+11.54%) ⬆️

@0xnm 0xnm merged commit eb75a0e into develop Dec 13, 2022
@0xnm 0xnm deleted the nogorodnikov/exclude-generated-files-from-detekt-run branch December 13, 2022 09:43
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants