Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share RawBatchEvent forgery for tests between the modules #1680

Merged
merged 1 commit into from Oct 26, 2023

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 25, 2023

What does this PR do?

Just a minor improvement to share RawBatchEvent forgery, so that is can be used in tests in different modules.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner October 25, 2023 12:15
mariusc83
mariusc83 previously approved these changes Oct 25, 2023
xgouchet
xgouchet previously approved these changes Oct 26, 2023
Copy link
Collaborator

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@codecov-commenter
Copy link

Codecov Report

Merging #1680 (fa17561) into nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline (4a3f24c) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@                                      Coverage Diff                                       @@
##           nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline    #1680      +/-   ##
==============================================================================================
- Coverage                                                       83.71%   83.66%   -0.05%     
==============================================================================================
  Files                                                             462      462              
  Lines                                                           15843    15840       -3     
  Branches                                                         2363     2362       -1     
==============================================================================================
- Hits                                                            13262    13252      -10     
- Misses                                                           1943     1948       +5     
- Partials                                                          638      640       +2     

see 15 files with indirect coverage changes

Base automatically changed from nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline to develop October 26, 2023 09:47
@0xnm 0xnm dismissed stale reviews from xgouchet and mariusc83 October 26, 2023 09:47

The base branch was changed.

@0xnm 0xnm merged commit a77ddd4 into develop Oct 26, 2023
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/share-rawbatchevent-forgery-in-fixtures branch October 26, 2023 10:11
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants