Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch processing level reporting in core configuration telemetry #1698

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 15, 2023

What does this PR do?

batchProcessingLevel has type Int and not Long, this difference made it evaluate to null when extracted from the message bus and safe-casted to Long.

Additional Notes

We probably need to come up with some approach regarding testing the things going through the message bus.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners November 15, 2023 09:13
@codecov-commenter
Copy link

Codecov Report

Merging #1698 (1b7c88e) into develop (8196669) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1698      +/-   ##
===========================================
- Coverage    83.40%   83.39%   -0.02%     
===========================================
  Files          465      465              
  Lines        16074    16071       -3     
  Branches      2383     2382       -1     
===========================================
- Hits         13406    13401       -5     
+ Misses        2025     2024       -1     
- Partials       643      646       +3     
Files Coverage Δ
...d/telemetry/internal/TelemetryCoreConfiguration.kt 88.89% <100.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 80.12% <100.00%> (-0.60%) ⬇️

... and 18 files with indirect coverage changes

@0xnm 0xnm merged commit 131e3d4 into develop Nov 16, 2023
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/fix-batch-processing-level-reporting-in-core-configuration-telemetry branch November 16, 2023 08:05
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants