(4/9) RUM-2127 Add synthetics info to RUM Views #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1717 +/- ##
===========================================
- Coverage 83.41% 83.30% -0.11%
===========================================
Files 465 465
Lines 16092 16103 +11
Branches 2386 2389 +3
===========================================
- Hits 13422 13413 -9
- Misses 2025 2038 +13
- Partials 645 652 +7
|
0xnm
reviewed
Nov 15, 2023
| @@ -903,77 +907,6 @@ internal class RumViewScopeTest { | |||
| assertThat(result2).isNull() | |||
| } | |||
|
|
|||
| @Test | |||
| fun `𝕄 send event 𝕎 handleEvent(StopView) on active view`( | |||
There was a problem hiding this comment.
why do we remove this test? I can see similar test is added with synthetics session, but then shouldn't this test assert user session type then instead of removing it?
There was a problem hiding this comment.
That must have been a cut-paste instead of a copy paste, fixed
mariusc83
reviewed
Nov 16, 2023
| @@ -697,6 +697,23 @@ internal open class RumViewScope( | |||
| currentViewId | |||
| ) | |||
| val replayStats = ViewEvent.ReplayStats(recordsCount = sessionReplayRecordsCount) | |||
| val syntheticsAttribute = if ( | |||
There was a problem hiding this comment.
maybe we should extract these methods ?
mariusc83
approved these changes
Nov 16, 2023
xgouchet
force-pushed
the
xgouchet/RUM-2127/4_read_synthetics_info
branch
from
b94fd27
to
e553692
Compare
0xnm
approved these changes
Nov 16, 2023
Base automatically changed from
xgouchet/RUM-2127/3_read_synthetics_info
to
develop
November 16, 2023 09:06
xgouchet
force-pushed
the
xgouchet/RUM-2127/4_read_synthetics_info
branch
from
e553692
to
33ebc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created automatically by the CI
Add synthetics info to RUM Views.
The info is read from the RUM context and converted into the relevant attributes at write time.