Fix flaky test in WebViewRumEventConsumerTest #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Nov 15, 2023
mariusc83
approved these changes
Nov 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1724 +/- ##
===========================================
- Coverage 83.40% 83.36% -0.05%
===========================================
Files 465 465
Lines 16074 16071 -3
Branches 2383 2382 -1
===========================================
- Hits 13406 13396 -10
- Misses 2025 2032 +7
Partials 643 643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a test that was randomly failing locally and in CI
Motivation
Test and CI reliability
Additional Notes
The test relied on several threads sending events to the WebViewRumEventConsumerTest. But the assertions expected the events to be processed in the original order, which, on many occasion (10% to 25% of test runs) wasn't true, meaning the assertion would fail.