Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1017: Unregister RUM monitor when associated RUM feature is stopped #1725

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Nov 16, 2023

What does this PR do?

This change removes RUM monitor for the given RUM feature (or SDK instance in other words), when the feature is stopped.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners November 16, 2023 09:29
@0xnm 0xnm force-pushed the nogorodnikov/rum-1017/clean-up-registered-rum-monitor-when-rum-feature-is-stopped branch from 7f0cf88 to ae0408f Compare November 16, 2023 09:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Merging #1725 (ae0408f) into develop (50e6072) will decrease coverage by 0.02%.
Report is 8 commits behind head on develop.
The diff coverage is 81.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1725      +/-   ##
===========================================
- Coverage    83.41%   83.38%   -0.02%     
===========================================
  Files          465      465              
  Lines        16092    16093       +1     
  Branches      2386     2385       -1     
===========================================
- Hits         13422    13419       -3     
- Misses        2025     2035      +10     
+ Partials       645      639       -6     
Files Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.21% <100.00%> (+0.35%) ⬆️
...kotlin/com/datadog/android/rum/GlobalRumMonitor.kt 81.25% <80.00%> (-1.51%) ⬇️

... and 21 files with indirect coverage changes

@0xnm 0xnm merged commit 8c57c9c into develop Nov 16, 2023
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1017/clean-up-registered-rum-monitor-when-rum-feature-is-stopped branch November 16, 2023 16:02
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants