Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1823: Add buildId to the RUM error and Log events #1756

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Dec 8, 2023

What does this PR do?

This PR adds buildId support for RUM error events and Log events.

buildId will be generated by the Datadog Gradle Plugin (see DataDog/dd-sdk-android-gradle-plugin#211) only for builds which are minified.

Once attached to RUM error events and Logs events, it will be used for the symbolication.

NB: although build_id is declared in the common schema for RUM events, this PR adds it only for error events.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm force-pushed the nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events branch from fca53be to 742d249 Compare December 8, 2023 10:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Merging #1756 (17c7c40) into develop (c14efb3) will decrease coverage by 0.06%.
Report is 2 commits behind head on develop.
The diff coverage is 92.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1756      +/-   ##
===========================================
- Coverage    83.37%   83.31%   -0.06%     
===========================================
  Files          489      489              
  Lines        17888    17882       -6     
  Branches      2665     2659       -6     
===========================================
- Hits         14913    14897      -16     
- Misses        2245     2252       +7     
- Partials       730      733       +3     
Files Coverage Δ
.../com/datadog/android/api/context/DatadogContext.kt 100.00% <100.00%> (ø)
...og/android/core/internal/DatadogContextProvider.kt 97.62% <100.00%> (+0.06%) ⬆️
...android/log/internal/domain/DatadogLogGenerator.kt 98.08% <100.00%> (+0.01%) ⬆️
...g/android/rum/internal/DatadogLateCrashReporter.kt 86.52% <100.00%> (+0.08%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 93.55% <100.00%> (-1.06%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 93.67% <100.00%> (-0.86%) ⬇️
...n/com/datadog/android/core/internal/CoreFeature.kt 87.23% <94.74%> (+0.46%) ⬆️
...tadog/android/core/internal/NoOpContextProvider.kt 3.33% <0.00%> (-0.11%) ⬇️

... and 26 files with indirect coverage changes

@0xnm 0xnm marked this pull request as ready for review December 8, 2023 13:20
@0xnm 0xnm requested review from a team as code owners December 8, 2023 13:20
@0xnm 0xnm force-pushed the nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events branch from 742d249 to 86834e6 Compare December 13, 2023 13:55
@0xnm 0xnm requested a review from xgouchet December 13, 2023 13:56
@0xnm 0xnm mentioned this pull request Feb 13, 2024
3 tasks
@0xnm 0xnm force-pushed the nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events branch from 86834e6 to 17c7c40 Compare April 3, 2024 11:59
@0xnm 0xnm requested review from xgouchet and mariusc83 April 3, 2024 12:05
@0xnm 0xnm merged commit f5aebeb into develop Apr 5, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1823/attach-build-id-to-rum-error-and-log-events branch April 5, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants