Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reading BUILDENV_HOST_IP variable to the job script definition #1801

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Jan 2, 2024

What does this PR do?

We've changed the runner type here #1789 and since it is now k8s-based, the variables that depends on information related to k8s resources (host IP) needs to be referenced directly from the job otherwise is not going to work.

This PR fixes dd-trace-java bootstrap which was failing, because BUILDENV_HOST_IP wasn't available at the variables set stage.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm changed the title Move reading BUILDENV_HOST_IP variable to the stage script definition Move reading BUILDENV_HOST_IP variable to the job script definition Jan 2, 2024
@0xnm 0xnm changed the title Move reading BUILDENV_HOST_IP variable to the job script definition Move reading BUILDENV_HOST_IP variable to the job script definition Jan 2, 2024
@0xnm 0xnm force-pushed the nogorodnikov/move-setting-dd-agent-host-to-stage branch from 8783e4d to 4c92f31 Compare January 2, 2024 13:37
@0xnm 0xnm marked this pull request as ready for review January 2, 2024 13:55
@0xnm 0xnm requested review from a team as code owners January 2, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

Merging #1801 (4c92f31) into develop (12d25e5) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
+ Coverage    83.41%   83.51%   +0.11%     
===========================================
  Files          466      466              
  Lines        16371    16348      -23     
  Branches      2453     2454       +1     
===========================================
- Hits         13655    13653       -2     
+ Misses        2041     2031      -10     
+ Partials       675      664      -11     

see 20 files with indirect coverage changes

@0xnm 0xnm merged commit 5a1b601 into develop Jan 3, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/move-setting-dd-agent-host-to-stage branch January 3, 2024 09:55
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants